<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104932/">http://git.reviewboard.kde.org/r/104932/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ghislain Mary.</div>
<p style="color: grey;"><i>Updated May 24, 2012, 2:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This new patch is quite different compared to the last one. Here are the changes:
- Fixed the issues reported by Milian.
- Fixed the filtering in nested view (it was not working at all with the previous patch)
- Replaced the search line edit by a filter action (as it is done in the projectmanagerview plugin)
- Changed some icons (those of the project, "Base classes" and "Derived classes" directories). Any better icon ideas are welcome!
See the attached screenshot to see what it looks like.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add nested view in the class browser plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It enables the user to navigate the project tree and list the classes defined in each directory of the project.
Some more work would be needed after this to improve the search function. I think we should replace the search lineedit by a "Filter..." action as in the projectmanagerview plugin so it is more consistent. And then when the user enters a filter we should use automatically the flat view because otherwise the user will probably not see the result of his filtering.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used it on the kdevplatform and kdevelop sources and have seen no problem.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=212583">212583</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/classbrowser/classmodel.h <span style="color: grey">(fd1eed5)</span></li>
<li>plugins/classbrowser/classmodel.cpp <span style="color: grey">(f9956c6)</span></li>
<li>plugins/classbrowser/classmodelnode.h <span style="color: grey">(739868b)</span></li>
<li>plugins/classbrowser/classmodelnode.cpp <span style="color: grey">(334f424)</span></li>
<li>plugins/classbrowser/classwidget.h <span style="color: grey">(1e1ed58)</span></li>
<li>plugins/classbrowser/classwidget.cpp <span style="color: grey">(f5a9517)</span></li>
<li>plugins/classbrowser/projectfolder.h <span style="color: grey">(d951a86)</span></li>
<li>plugins/classbrowser/projectfolder.cpp <span style="color: grey">(419cb79)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104932/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104932/s/576/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/05/24/ClassBrowser_400x100.png" style="border: 1px black solid;" alt="Nested view in class browser plugin" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>