Review Request: Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.

Andrew Fuller mactalla.obair at gmail.com
Sat Jan 7 02:45:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103619/
-----------------------------------------------------------

(Updated Jan. 7, 2012, 2:45 a.m.)


Review request for KDevelop.


Changes
-------

The project tree layout is now stored in the session configuration.

A new signal was added to SessionController "quittingSession" that is emitted immediately before quitSession.  ProjectTreeView connects to this to ensure the project is still around when saving its state.  The projectLoaded signal is used for restoring state.  This is done for two reasons: 1. in a single-project session, the ProjectTreeView can restore the tree immediately after populating the tree, and 2. in a multi-project session the ProjectTreeView can restore the state of each project as it is populated rather than waiting for the slowest.

Core made explicit that SessionController was @internal.  I'm not sure why SessionController is to not be exposed, but working with that means that plugin/projectmanagerview now links against shell in order to access Core.


Summary (updated)
-----------------

Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.


Description (updated)
-------

Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.


Diffs (updated)
-----

  plugins/projectmanagerview/CMakeLists.txt 7b58e8e5489819b0370f5d55e0218f063da90af2 
  plugins/projectmanagerview/projecttreeview.h 16893f0713b83a78a5b025a55fcfa082265d4419 
  plugins/projectmanagerview/projecttreeview.cpp 8237af513627c0459d571de2bccc275e8a4b0ae9 
  project/CMakeLists.txt bac4b22b8a9966f4efe4080a6d24e0de17c48e12 
  project/projectmodelsaver.h PRE-CREATION 
  project/projectmodelsaver.cpp PRE-CREATION 
  shell/sessioncontroller.h 551894d4131218b9ab2640e28f2c354ce319a105 
  shell/sessioncontroller.cpp d2ee8732710e0e4bded56e547d83a3906b20b018 

Diff: http://git.reviewboard.kde.org/r/103619/diff/diff


Testing
-------

Load a session, Exit, and return.  Voilà!  The tree is right where you left it.


Thanks,

Andrew Fuller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120107/a1cf2d90/attachment.html>


More information about the KDevelop-devel mailing list