<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103619/">http://git.reviewboard.kde.org/r/103619/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrew Fuller.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2012, 2:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The project tree layout is now stored in the session configuration.
A new signal was added to SessionController "quittingSession" that is emitted immediately before quitSession. ProjectTreeView connects to this to ensure the project is still around when saving its state. The projectLoaded signal is used for restoring state. This is done for two reasons: 1. in a single-project session, the ProjectTreeView can restore the tree immediately after populating the tree, and 2. in a multi-project session the ProjectTreeView can restore the state of each project as it is populated rather than waiting for the slowest.
Core made explicit that SessionController was @internal. I'm not sure why SessionController is to not be exposed, but working with that means that plugin/projectmanagerview now links against shell in order to access Core.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load a session, Exit, and return. Voilà! The tree is right where you left it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(7b58e8e5489819b0370f5d55e0218f063da90af2)</span></li>
<li>plugins/projectmanagerview/projecttreeview.h <span style="color: grey">(16893f0713b83a78a5b025a55fcfa082265d4419)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(8237af513627c0459d571de2bccc275e8a4b0ae9)</span></li>
<li>project/CMakeLists.txt <span style="color: grey">(bac4b22b8a9966f4efe4080a6d24e0de17c48e12)</span></li>
<li>project/projectmodelsaver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projectmodelsaver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/sessioncontroller.h <span style="color: grey">(551894d4131218b9ab2640e28f2c354ce319a105)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(d2ee8732710e0e4bded56e547d83a3906b20b018)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>