D23281: Change MPRIS control buttons color to match album art

Simon Redman simon at ergotech.com
Sun Aug 25 22:03:11 BST 2019


That reply went just to me, I have re-added the list

No problem. When you're ready for us to look at it just be sure to post
it to GitLab. (No need to email the list or anything at that point, the
developers are already subscribed to GitLab emails)

Thanks,
Simon

On 8/25/19 2:00 PM, Kurt Wilson wrote:
> I hope this is the right way to reply. I set the diff as private a few
> hours after submitting it because I found a few bugs and edge cases
> which needs some more work
>
> On Sun, Aug 25, 2019, 4:33 PM Simon Redman <simon at ergotech.com
> <mailto:simon at ergotech.com>> wrote:
>
>     +CC Kurt for real this time :)
>
>     I just updated the documentation. Take a look and let me know if
>     you get lost so I can improve it.
>     https://community.kde.org/Infrastructure/Github_Mirror#How_do_I_submit_.E2.80.9CPull_Requests.E2.80.9D.3F
>
>     On 8/25/19 1:03 PM, Albert Vaca Cintora wrote:
>>     +CCd Kurt who might not be in the list
>>
>>     Looks like Kurt (sorry Kurt!) first sent a Github PR for this
>>     same patch: https://github.com/KDE/kdeconnect-android/pull/14
>>
>>     Which got closed with a link
>>     to https://community.kde.org/Infrastructure/Github_Mirror
>>
>>     Which points to Phabricator instead of GitLab. This needs updating :/
>>
>>
>>
>>     On Fri, Aug 23, 2019 at 12:13 PM Matthijs Tijink
>>     <matthijstijink at gmail.com <mailto:matthijstijink at gmail.com>> wrote:
>>
>>         Dear Kurt,
>>
>>          
>>
>>         I don't know if I'm the only one, but I cannot view your
>>         patches (Phabricator denies me). Since we've moved to Gitlab
>>         (https://invent.kde.org), could you try resubmitting your
>>         change there?
>>
>>          
>>
>>         The idea of changing buttons based on album art definitely
>>         sounds interesting!
>>
>>          
>>
>>         Kind regards, Matthijs Tijink
>>
>>         Op dinsdag 20 augustus 2019 00:26:21 CEST schreef Kurt Wilson:
>>
>>         View Revision <https://phabricator.kde.org/D23281>
>>
>>         kurtwilson edited the summary of this revision. (Show
>>         Details)
>>         <https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-7lszdizcuyznzax/>
>>
>>
>>
>>         CHANGES TO REVISION SUMMARY
>>
>>         Inspired by how Android's color selection for LargeIcon media
>>         notifications
>>
>>
>>         REPOSITORY
>>
>>         R225 KDE Connect - Android application
>>
>>
>>         REVISION DETAIL
>>
>>         https://phabricator.kde.org/D23281
>>
>>
>>         To: kurtwilson, VDG, KDE Connect
>>         Cc: kdeconnect, ritwizsinha, ewentzel, dshelley,
>>         pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp,
>>         shivanshukantprasad, skymoore, fbampaloukas, brute4s99,
>>         wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda,
>>         timothyc, Danial0_0, johnq, Pitel, domson, adeen-s,
>>         SemperPeritus, daniel.z.tg <http://daniel.z.tg>, jeanv,
>>         seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov,
>>         tctara, apol
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190825/327eda1a/attachment-0001.html>


More information about the KDEConnect mailing list