<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
That reply went just to me, I have re-added the list<br>
<br>
No problem. When you're ready for us to look at it just be sure to
post it to GitLab. (No need to email the list or anything at that
point, the developers are already subscribed to GitLab emails)<br>
<br>
Thanks,<br>
Simon<br>
<br>
<div class="moz-cite-prefix">On 8/25/19 2:00 PM, Kurt Wilson wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMhcU7Pe-Zz1tMrGNAD-CSB_djb-_kTe3y1G8_Loks+pzVtyiw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="auto">I hope this is the right way to reply. I set the
diff as private a few hours after submitting it because I found
a few bugs and edge cases which needs some more work</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, Aug 25, 2019, 4:33 PM
Simon Redman <<a href="mailto:simon@ergotech.com"
moz-do-not-send="true">simon@ergotech.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> +CC Kurt for real this
time :)<br>
<br>
I just updated the documentation. Take a look and let me
know if you get lost so I can improve it.<br>
<a class="m_-4747453085285205767moz-txt-link-freetext"
href="https://community.kde.org/Infrastructure/Github_Mirror#How_do_I_submit_.E2.80.9CPull_Requests.E2.80.9D.3F"
target="_blank" rel="noreferrer" moz-do-not-send="true">https://community.kde.org/Infrastructure/Github_Mirror#How_do_I_submit_.E2.80.9CPull_Requests.E2.80.9D.3F</a><br>
<br>
<div class="m_-4747453085285205767moz-cite-prefix">On
8/25/19 1:03 PM, Albert Vaca Cintora wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>+CCd Kurt who might not be in the list<br>
</div>
<div><br>
</div>
Looks like Kurt (sorry Kurt!) first sent a Github PR for
this same patch: <a
href="https://github.com/KDE/kdeconnect-android/pull/14"
target="_blank" rel="noreferrer"
moz-do-not-send="true">https://github.com/KDE/kdeconnect-android/pull/14</a>
<div><br>
</div>
<div>Which got closed with a link to <a
href="https://community.kde.org/Infrastructure/Github_Mirror"
target="_blank" rel="noreferrer"
moz-do-not-send="true">https://community.kde.org/Infrastructure/Github_Mirror</a></div>
<div><br>
</div>
<div>Which points to Phabricator instead of GitLab. This
needs updating :/</div>
<div><br>
</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Aug 23, 2019
at 12:13 PM Matthijs Tijink <<a
href="mailto:matthijstijink@gmail.com"
target="_blank" rel="noreferrer"
moz-do-not-send="true">matthijstijink@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p style="margin:0px;text-indent:0px">Dear Kurt,</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">I don't know
if I'm the only one, but I cannot view your
patches (Phabricator denies me). Since we've moved
to Gitlab (<a href="https://invent.kde.org"
target="_blank" rel="noreferrer"
moz-do-not-send="true">https://invent.kde.org</a>),
could you try resubmitting your change there?</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">The idea of
changing buttons based on album art definitely
sounds interesting!</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">Kind regards,
Matthijs Tijink<br>
<br>
Op dinsdag 20 augustus 2019 00:26:21 CEST schreef
Kurt Wilson:<br>
</p>
<p style="margin:12px 40px;text-indent:0px"><a
href="https://phabricator.kde.org/D23281"
target="_blank" rel="noreferrer"
moz-do-not-send="true"><span
style="font-weight:600;color:rgb(70,76,92);background-color:rgb(247,247,249)">View
Revision</span></a></p>
<table style="margin:0px 40px" cellspacing="2"
cellpadding="0" border="0">
<tbody>
<tr>
<td>
<p style="margin:0px;text-indent:0px">kurtwilson
edited the summary of this revision. <a
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-7lszdizcuyznzax/"
target="_blank" rel="noreferrer"
moz-do-not-send="true"><span
style="text-decoration:underline;color:rgb(41,128,185)">(Show
Details)</span></a> </p>
</td>
</tr>
</tbody>
</table>
<p style="margin:0px;text-indent:0px"><br>
</p>
<p style="margin:0px 40px;text-indent:0px"><span
style="font-weight:600">CHANGES TO REVISION
SUMMARY</span></p>
<p style="margin:0px 40px;text-indent:0px"><span
style="color:rgb(116,119,125)">Inspired by </span><span
style="color:rgb(51,51,51);background-color:rgba(251,175,175,0.698)">how
</span><span style="color:rgb(116,119,125)">Android's
color selection for LargeIcon media
notifications</span></p>
<p style="margin:0px;text-indent:0px"><br>
</p>
<p style="margin:0px 40px;text-indent:0px"><span
style="font-weight:600">REPOSITORY</span></p>
<p style="margin:0px 40px;text-indent:0px">R225 KDE
Connect - Android application</p>
<p style="margin:0px;text-indent:0px"><br>
</p>
<p style="margin:0px 40px;text-indent:0px"><span
style="font-weight:600">REVISION DETAIL</span></p>
<p style="margin:0px 40px;text-indent:0px"><a
href="https://phabricator.kde.org/D23281"
target="_blank" rel="noreferrer"
moz-do-not-send="true"><span
style="text-decoration:underline;color:rgb(41,128,185)">https://phabricator.kde.org/D23281</span></a></p>
<p style="margin:0px;text-indent:0px"><br>
</p>
<p style="margin:0px 40px;text-indent:0px"><span
style="font-weight:600">To: </span>kurtwilson,
VDG, KDE Connect<br>
<span style="font-weight:600">Cc: </span>kdeconnect,
ritwizsinha, ewentzel, dshelley, pawelkwiecinski,
ctakano, vporvaznik, mschroeder, varunp,
shivanshukantprasad, skymoore, fbampaloukas,
brute4s99, wistak, anoopv, dvalencia, rmenezes,
julioc, Leptopoda, timothyc, Danial0_0, johnq,
Pitel, domson, adeen-s, SemperPeritus, <a
href="http://daniel.z.tg" target="_blank"
rel="noreferrer" moz-do-not-send="true">daniel.z.tg</a>,
jeanv, seebauer, bugzy, MayeulC, lemuel,
menasshock, mikesomov, tctara, apol<br>
</p>
<p style="margin:0px;text-indent:0px"><br>
</p>
</div>
</blockquote>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>