Review Request: Implement close button in plasmoid

Lasath Fernando kde at lasath.org
Mon Feb 6 12:49:55 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103879/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

This makes ConversationsModel remove every conversation whose Tp::TextChannel becomes invalid. Since this plasmoid is primarily meant to allow for quick response for incomming chats, I don't think closed channels have any place here.

The close button calls requestClose in the text channel so it'll be closed and removed from the plasmoid.


This addresses bug 292974.
    http://bugs.kde.org/show_bug.cgi?id=292974


Diffs
-----

  plasmoid/declarative-plugin/conversation.h a072a51 
  plasmoid/declarative-plugin/conversation.cpp 89cd4e8 
  plasmoid/declarative-plugin/conversations-model.h 6d38c3d 
  plasmoid/declarative-plugin/conversations-model.cpp ad13f67 
  plasmoid/declarative-plugin/messages-model.h 8da3626 
  plasmoid/declarative-plugin/messages-model.cpp 3b4d4db 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 4de2ef3 

Diff: http://git.reviewboard.kde.org/r/103879/diff/diff


Testing
-------

Opened a bunch of chats, then closed them.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120206/8e1edc13/attachment.html>


More information about the KDE-Telepathy mailing list