<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103879/">http://git.reviewboard.kde.org/r/103879/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes ConversationsModel remove every conversation whose Tp::TextChannel becomes invalid. Since this plasmoid is primarily meant to allow for quick response for incomming chats, I don't think closed channels have any place here.

The close button calls requestClose in the text channel so it'll be closed and removed from the plasmoid.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened a bunch of chats, then closed them.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=292974">292974</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasmoid/declarative-plugin/conversation.h <span style="color: grey">(a072a51)</span></li>

 <li>plasmoid/declarative-plugin/conversation.cpp <span style="color: grey">(89cd4e8)</span></li>

 <li>plasmoid/declarative-plugin/conversations-model.h <span style="color: grey">(6d38c3d)</span></li>

 <li>plasmoid/declarative-plugin/conversations-model.cpp <span style="color: grey">(ad13f67)</span></li>

 <li>plasmoid/declarative-plugin/messages-model.h <span style="color: grey">(8da3626)</span></li>

 <li>plasmoid/declarative-plugin/messages-model.cpp <span style="color: grey">(3b4d4db)</span></li>

 <li>plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml <span style="color: grey">(4de2ef3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103879/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>