Review Request: Replace Feedback widget with KMessageWidget

[Dario Freddi]

> On Dec. 13, 2011, 7:39 p.m., Martin Klapetek wrote:
> > src/KCMTelepathyAccounts/feedback-widget.cpp, line 56
> > <http://git.reviewboard.kde.org/r/103398/diff/2/?file=43307#file43307line56>
> >
> >     Let's make the first message bold as it is a title -- QString("<b>%1</b>\n%2").arg...
> 
> Dario Freddi wrote:
>     Not agreeing. Nuno also warned me against using bold, and I told you that yesterday :P
> 
> Martin Klapetek wrote:
>     Yes, I know :P But if you look at the attached screenshots, the first one looks imho better, because it visually divides the title and the detailed message. If they both look the same, then there's no point for having these two things separated.

ok, let's try using bold for now, then we'll get through UI review again :) Dominik, please implement Martin's suggestion before shipping, and thanks for your patches, you rock!


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103398/#review8933
-----------------------------------------------------------


On Dec. 13, 2011, 4:55 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103398/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 4:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Replaced all occurrences of FeedbackWidget with KMessageWidget.
> Also turned two Informative messages into Error messages to make it consistent.
> 
> 
> This addresses bug 283869.
>     http://bugs.kde.org/show_bug.cgi?id=283869
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/account-edit-widget.h 52dc89d 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp 14f1b75 
>   src/KCMTelepathyAccounts/feedback-widget.h e547857 
>   src/KCMTelepathyAccounts/feedback-widget.cpp 057456a 
>   src/KCMTelepathyAccounts/parameter-edit-model.h 3b2b08b 
>   src/KCMTelepathyAccounts/parameter-edit-model.cpp f461674 
>   src/add-account-assistant.h b85d44e 
>   src/add-account-assistant.cpp 1c2e90d 
>   src/salut-details-dialog.h 5a36adc 
>   src/salut-details-dialog.cpp 46fb94c 
>   src/salut-enabler.h 8a86133 
>   src/salut-enabler.cpp ca7a46e 
> 
> Diff: http://git.reviewboard.kde.org/r/103398/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Old version with FeedbackWidget
>   http://git.reviewboard.kde.org/r/103398/s/367/
> New version with KMessageWidget
>   http://git.reviewboard.kde.org/r/103398/s/368/
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111213/63abe1c4/attachment-0001.html>