<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103398/">http://git.reviewboard.kde.org/r/103398/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2011, 7:39 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103398/diff/2/?file=43307#file43307line56" style="color: black; font-weight: bold; text-decoration: underline;">src/KCMTelepathyAccounts/feedback-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setText</span><span class="p">(</span><span class="n">text</span><span class="p">,</span> <span class="n">type</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span class="p">(</span><span class="s">"%1</span><span class="se">\n</span><span class="s">%2"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">text</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">comment</span><span class="p">),</span> <span class="n">type</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's make the first message bold as it is a title -- QString("<b>%1</b>\n%2").arg...</pre>
</blockquote>
<p>On December 13th, 2011, 7:50 p.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not agreeing. Nuno also warned me against using bold, and I told you that yesterday :P</pre>
</blockquote>
<p>On December 13th, 2011, 7:55 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I know :P But if you look at the attached screenshots, the first one looks imho better, because it visually divides the title and the detailed message. If they both look the same, then there's no point for having these two things separated.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, let's try using bold for now, then we'll get through UI review again :) Dominik, please implement Martin's suggestion before shipping, and thanks for your patches, you rock!</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 13th, 2011, 4:55 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2011, 4:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replaced all occurrences of FeedbackWidget with KMessageWidget.
Also turned two Informative messages into Error messages to make it consistent.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283869">283869</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(52dc89d)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(14f1b75)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.h <span style="color: grey">(e547857)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.cpp <span style="color: grey">(057456a)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(3b2b08b)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(f461674)</span></li>
<li>src/add-account-assistant.h <span style="color: grey">(b85d44e)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(1c2e90d)</span></li>
<li>src/salut-details-dialog.h <span style="color: grey">(5a36adc)</span></li>
<li>src/salut-details-dialog.cpp <span style="color: grey">(46fb94c)</span></li>
<li>src/salut-enabler.h <span style="color: grey">(8a86133)</span></li>
<li>src/salut-enabler.cpp <span style="color: grey">(ca7a46e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103398/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103398/s/367/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/12/FeedbackWidget_400x100.png" style="border: 1px black solid;" alt="Old version with FeedbackWidget" /></a>
<a href="http://git.reviewboard.kde.org/r/103398/s/368/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/12/KMessageWidget_400x100.png" style="border: 1px black solid;" alt="New version with KMessageWidget" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>