Review Request: Fix bug 270345 : URL parser recognizes addresses starting with http:// or https:// only

Francesco Nwokeka francesco.nwokeka at gmail.com
Thu Apr 14 11:38:33 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101080/
-----------------------------------------------------------

(Updated April 14, 2011, 9:38 a.m.)


Review request for Telepathy.


Changes
-------

Better url recognition with better regex.
Newlines truncate the link
Unwanted chars not allowed in link.


Summary
-------

Simple patch to recognize other links other than http(s). Added smb and (s)ftp. if there are others to add please let me know


This addresses bug 270345.
    http://bugs.kde.org/show_bug.cgi?id=270345


Diffs (updated)
-----

  lib/adium-theme-view.cpp 8a8818c 

Diff: http://git.reviewboard.kde.org/r/101080/diff


Testing
-------


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110414/d2fd7e5d/attachment.htm 


More information about the KDE-Telepathy mailing list