Review Request: Fix bug 270345 : URL parser recognizes addresses starting with http:// or https:// only

[Francesco Nwokeka]

> On April 12, 2011, 12:14 a.m., Lasse Liehu wrote:
> > lib/adium-theme-view.cpp, line 365
> > <http://git.reviewboard.kde.org/r/101080/diff/3/?file=14201#file14201line365>
> >
> >     I meant adding "<" here, like: "[^ \t\n\r\f\v]" -> "[^ \t\n\r\f\v<]". It would alone do the trick (no need to check for <br/> or anything) and also protect us from all HTML tags. It's also safe, as the < characters user typed are escaped.
> 
> Francesco Nwokeka wrote:
>     Yep, that's a cleaner and better solution. Applied. Removing uneeded code

Actually no. The regex is for "accepting" a link. The search for "<" or ">" chars has to be done after.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101080/#review2568
-----------------------------------------------------------


On April 11, 2011, 9:59 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101080/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 9:59 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Simple patch to recognize other links other than http(s). Added smb and (s)ftp. if there are others to add please let me know
> 
> 
> This addresses bug 270345.
>     http://bugs.kde.org/show_bug.cgi?id=270345
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.cpp 6c78889 
> 
> Diff: http://git.reviewboard.kde.org/r/101080/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/dde132b6/attachment.htm