Review Request 111814: resolve BC issues in libnm-qt

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111814/#review36929
-----------------------------------------------------------



settings/adslsetting.h
<http://git.reviewboard.kde.org/r/111814/#comment27234>

    For the sake of code style the line with macros should go first. Please move this line to after the "private:" line. Do the same for the other classes.
    
    For wirelessnetwork.h we can move the private methods and variables to its private class too. We need to use Q_DECLARE_PUBLIC(WirelessNetwork) in wirelessnetwork_p.h and change the WirelessNetworkPrivate's constructor to receive the q-pointer. Then move all private methods from WirelessNetwork to WirelessNetworkPrivate and use the q-pointer when we need to access something from WiressNetwork.
    
    If you check those private methods they almost always use methods from WirelessNetworkPrivate, so it should not be that difficult to move them to the private class.
    
    We also should redeclare WirelessNetwork::{accessPointAppeared,accessPointDisappeared, updateStrength} using Q_PRIVATE_SLOT() macro.


- Lamarque Souza


On Aug. 1, 2013, 2:30 p.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111814/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 2:30 p.m.)
> 
> 
> Review request for Network Management, Jan Grulich and Lamarque Souza.
> 
> 
> Description
> -------
> 
> As agreed with lamarque on IRC, we should try to resolve any pending BC issues in libnm-qt before making its first official release.
> 
> Cf https://trello.com/c/cxR7AEAX/44-fix-binary-compatibiliy-issues-in-libmm-qt-and-libnm-qt
> 
> 
> Diffs
> -----
> 
>   accesspoint.cpp d934d53 
>   activeconnection.h 7f6ed12 
>   adsldevice.cpp 34a19ef 
>   bluetoothdevice.cpp 32f0d06 
>   bonddevice.cpp 25162e6 
>   bridgedevice.cpp 949913e 
>   device.h d3e9084 
>   infinibanddevice.cpp 4fe4625 
>   modemdevice.cpp 4ee63d2 
>   olpcmeshdevice.cpp 06beabc 
>   olpcmeshdevice_p.h 99eaa28 
>   settings/adslsetting.h c597ee5 
>   settings/bluetoothsetting.h 107f843 
>   settings/bondsetting.h 0f75cc5 
>   settings/bridgeportsetting.h 50b2261 
>   settings/bridgesetting.h dd0fa9e 
>   settings/cdmasetting.h c2465cf 
>   settings/gsmsetting.h 4307f2a 
>   settings/infinibandsetting.h 49310ab 
>   settings/ipv4setting.h 6bc1a97 
>   settings/ipv6setting.h 422865b 
>   settings/olpcmeshsetting.h 8f5637b 
>   settings/pppoesetting.h b2dd3d7 
>   settings/pppsetting.h cb82f8a 
>   settings/security8021xsetting.h b681981 
>   settings/serialsetting.h 0a2dc9f 
>   settings/setting.h d9b532d 
>   settings/vlansetting.h f04cdd9 
>   settings/vpnsetting.h 1304664 
>   settings/wimaxsetting.h 0cccca2 
>   settings/wiredsetting.h f7af177 
>   settings/wirelesssecuritysetting.h 2578836 
>   settings/wirelesssetting.h 91d1d8e 
>   vlandevice.cpp 8284428 
>   vpnconnection.cpp 18fe7d7 
>   vpnplugin.h 1aad58d 
>   wimaxdevice.cpp b68c55c 
>   wimaxnsp.cpp 90045ed 
>   wireddevice.cpp 2ccc8d8 
>   wirelessdevice.cpp 1744023 
> 
> Diff: http://git.reviewboard.kde.org/r/111814/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine, will be running it live from now on.
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130801/f4ed6149/attachment.html>