<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111814/">http://git.reviewboard.kde.org/r/111814/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111814/diff/2/?file=175791#file175791line79" style="color: black; font-weight: bold; text-decoration: underline;">settings/adslsetting.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_DECLARE_PRIVATE</span><span class="p">(</span><span class="n">AdslSetting</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_DECLARE_PRIVATE</span><span class="p">(</span><span class="n">AdslSetting</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the sake of code style the line with macros should go first. Please move this line to after the "private:" line. Do the same for the other classes.
For wirelessnetwork.h we can move the private methods and variables to its private class too. We need to use Q_DECLARE_PUBLIC(WirelessNetwork) in wirelessnetwork_p.h and change the WirelessNetworkPrivate's constructor to receive the q-pointer. Then move all private methods from WirelessNetwork to WirelessNetworkPrivate and use the q-pointer when we need to access something from WiressNetwork.
If you check those private methods they almost always use methods from WirelessNetworkPrivate, so it should not be that difficult to move them to the private class.
We also should redeclare WirelessNetwork::{accessPointAppeared,accessPointDisappeared, updateStrength} using Q_PRIVATE_SLOT() macro.</pre>
</div>
<br />
<p>- Lamarque</p>
<br />
<p>On August 1st, 2013, 2:30 p.m. UTC, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management, Jan Grulich and Lamarque Souza.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As agreed with lamarque on IRC, we should try to resolve any pending BC issues in libnm-qt before making its first official release.
Cf https://trello.com/c/cxR7AEAX/44-fix-binary-compatibiliy-issues-in-libmm-qt-and-libnm-qt</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles fine, will be running it live from now on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>accesspoint.cpp <span style="color: grey">(d934d53)</span></li>
<li>activeconnection.h <span style="color: grey">(7f6ed12)</span></li>
<li>adsldevice.cpp <span style="color: grey">(34a19ef)</span></li>
<li>bluetoothdevice.cpp <span style="color: grey">(32f0d06)</span></li>
<li>bonddevice.cpp <span style="color: grey">(25162e6)</span></li>
<li>bridgedevice.cpp <span style="color: grey">(949913e)</span></li>
<li>device.h <span style="color: grey">(d3e9084)</span></li>
<li>infinibanddevice.cpp <span style="color: grey">(4fe4625)</span></li>
<li>modemdevice.cpp <span style="color: grey">(4ee63d2)</span></li>
<li>olpcmeshdevice.cpp <span style="color: grey">(06beabc)</span></li>
<li>olpcmeshdevice_p.h <span style="color: grey">(99eaa28)</span></li>
<li>settings/adslsetting.h <span style="color: grey">(c597ee5)</span></li>
<li>settings/bluetoothsetting.h <span style="color: grey">(107f843)</span></li>
<li>settings/bondsetting.h <span style="color: grey">(0f75cc5)</span></li>
<li>settings/bridgeportsetting.h <span style="color: grey">(50b2261)</span></li>
<li>settings/bridgesetting.h <span style="color: grey">(dd0fa9e)</span></li>
<li>settings/cdmasetting.h <span style="color: grey">(c2465cf)</span></li>
<li>settings/gsmsetting.h <span style="color: grey">(4307f2a)</span></li>
<li>settings/infinibandsetting.h <span style="color: grey">(49310ab)</span></li>
<li>settings/ipv4setting.h <span style="color: grey">(6bc1a97)</span></li>
<li>settings/ipv6setting.h <span style="color: grey">(422865b)</span></li>
<li>settings/olpcmeshsetting.h <span style="color: grey">(8f5637b)</span></li>
<li>settings/pppoesetting.h <span style="color: grey">(b2dd3d7)</span></li>
<li>settings/pppsetting.h <span style="color: grey">(cb82f8a)</span></li>
<li>settings/security8021xsetting.h <span style="color: grey">(b681981)</span></li>
<li>settings/serialsetting.h <span style="color: grey">(0a2dc9f)</span></li>
<li>settings/setting.h <span style="color: grey">(d9b532d)</span></li>
<li>settings/vlansetting.h <span style="color: grey">(f04cdd9)</span></li>
<li>settings/vpnsetting.h <span style="color: grey">(1304664)</span></li>
<li>settings/wimaxsetting.h <span style="color: grey">(0cccca2)</span></li>
<li>settings/wiredsetting.h <span style="color: grey">(f7af177)</span></li>
<li>settings/wirelesssecuritysetting.h <span style="color: grey">(2578836)</span></li>
<li>settings/wirelesssetting.h <span style="color: grey">(91d1d8e)</span></li>
<li>vlandevice.cpp <span style="color: grey">(8284428)</span></li>
<li>vpnconnection.cpp <span style="color: grey">(18fe7d7)</span></li>
<li>vpnplugin.h <span style="color: grey">(1aad58d)</span></li>
<li>wimaxdevice.cpp <span style="color: grey">(b68c55c)</span></li>
<li>wimaxnsp.cpp <span style="color: grey">(90045ed)</span></li>
<li>wireddevice.cpp <span style="color: grey">(2ccc8d8)</span></li>
<li>wirelessdevice.cpp <span style="color: grey">(1744023)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>