Review Request 125022: Dragonplayer [patch]

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125022/#review85802
-----------------------------------------------------------


That's invidual patches, not invidiual review requests but whatever...


File Attachment: 5.patch - 5.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment441>

    This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.



File Attachment: 3.patch - 3.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment442>

    What's the problem with reloading that you are trying to solve? Because the change you propose is not actually reloading-on-end it's reload on toggle which, like the cursor restore this is way too broad and doesn't actualy fix whatever is missing the update, it simply blanket updates all the time.



File Attachment: 2.patch - 2.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment443>

    this was undone in a60f1ace56ae4ccb449ef73bb62df83427cfefbb why I do not know, I presume there was a plan for it. Please add Lukáš Tinkl to the reviewer list.



File Attachment: 1.patch - 1.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment444>

    Firstly what problem are you actually trying to solve here?
    
    Secondly this looks like a hack. A manually set cursor should reset as closely to where it was set as possible, the proposed change looks a lot like it's not clear which cursor override we are
    resetting here.



File Attachment: 4.patch - 4.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment445>

    trailing whitespaces



File Attachment: 4.patch - 4.patch
<https://git.reviewboard.kde.org//r/125022/#fcomment446>

    trailing whitespaces


- Harald Sitter


On Sept. 23, 2015, 4:53 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125022/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 4:53 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Dragon fixes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e2138c5 
>   misc/CMakeLists.txt 5628302 
>   misc/dragonplayer.notifyrc PRE-CREATION 
>   misc/dragonplayerui.rc 38a15c5 
>   src/app/CMakeLists.txt 2696e34 
>   src/app/audioView2.h cc94549 
>   src/app/audioView2.cpp 98ca473 
>   src/app/loadView.h 80eaddb 
>   src/app/loadView.cpp 0ae65ec 
>   src/app/main.cpp 2de3b35 
>   src/app/mainWindow.h bd9ac91 
>   src/app/mainWindow.cpp 777467b 
>   src/app/recentlyPlayedList.h c4d70de 
>   src/app/videoWindow.cpp 552069d 
> 
> Diff: https://git.reviewboard.kde.org/r/125022/diff/
> 
> 
> Testing
> -------
> 
> 1. Restore cursor after fullscreen video ends
> 2. Initialize analyzer on audio streams
> 3. Refresh recently played list after playback is stopped
> 4. Multiple applications support
> 5. Notifications for audio streams
> 
> 
> File Attachments
> ----------------
> 
> 1.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch
> 2.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch
> 3.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch
> 4.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/ea4bdd85-5e34-43f0-8c0f-70a357e42529__4.patch
> 5.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150923/6f0dc001/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia