<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125022/">https://git.reviewboard.kde.org/r/125022/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's invidual patches, not invidiual review requests but whatever...</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2455/#source/line37" style="color: black; font-weight: bold; font-size: 9pt;">5.patch</a>
<p>5.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>37</th>
<td><pre><span class="gi">+Name=Track Change</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2452/#source/line11" style="color: black; font-weight: bold; font-size: 9pt;">3.patch</a>
<p>3.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>11</th>
<td><pre><span class="gi">+ m_recentlyPlayed->loadEntries();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's the problem with reloading that you are trying to solve? Because the change you propose is not actually reloading-on-end it's reload on toggle which, like the cursor restore this is way too broad and doesn't actualy fix whatever is missing the update, it simply blanket updates all the time.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2451/#source/line9" style="color: black; font-weight: bold; font-size: 9pt;">2.patch</a>
<p>2.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>9</th>
<td><pre><span class="gi">+ setupAnalyzer();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this was undone in a60f1ace56ae4ccb449ef73bb62df83427cfefbb why I do not know, I presume there was a plan for it. Please add Lukáš Tinkl to the reviewer list.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2450/#source/line9" style="color: black; font-weight: bold; font-size: 9pt;">1.patch</a>
<p>1.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>9</th>
<td><pre><span class="gi">+ qApp->restoreOverrideCursor();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Firstly what problem are you actually trying to solve here?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Secondly this looks like a hack. A manually set cursor should reset as closely to where it was set as possible, the proposed change looks a lot like it's not clear which cursor override we are
resetting here.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2453/#source/line26" style="color: black; font-weight: bold; font-size: 9pt;">4.patch</a>
<p>4.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>26</th>
<td><pre><span class="gi">+ </span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">trailing whitespaces</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/125022/file/2453/#source/line28" style="color: black; font-weight: bold; font-size: 9pt;">4.patch</a>
<p>4.patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>28</th>
<td><pre><span class="gi">+ </span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">trailing whitespaces</p></pre>
</div>
<br />
<p>- Harald Sitter</p>
<br />
<p>On September 23rd, 2015, 4:53 a.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2015, 4:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dragon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dragon fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1. Restore cursor after fullscreen video ends
2. Initialize analyzer on audio streams
3. Refresh recently played list after playback is stopped
4. Multiple applications support
5. Notifications for audio streams</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e2138c5)</span></li>
<li>misc/CMakeLists.txt <span style="color: grey">(5628302)</span></li>
<li>misc/dragonplayer.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/dragonplayerui.rc <span style="color: grey">(38a15c5)</span></li>
<li>src/app/CMakeLists.txt <span style="color: grey">(2696e34)</span></li>
<li>src/app/audioView2.h <span style="color: grey">(cc94549)</span></li>
<li>src/app/audioView2.cpp <span style="color: grey">(98ca473)</span></li>
<li>src/app/loadView.h <span style="color: grey">(80eaddb)</span></li>
<li>src/app/loadView.cpp <span style="color: grey">(0ae65ec)</span></li>
<li>src/app/main.cpp <span style="color: grey">(2de3b35)</span></li>
<li>src/app/mainWindow.h <span style="color: grey">(bd9ac91)</span></li>
<li>src/app/mainWindow.cpp <span style="color: grey">(777467b)</span></li>
<li>src/app/recentlyPlayedList.h <span style="color: grey">(c4d70de)</span></li>
<li>src/app/videoWindow.cpp <span style="color: grey">(552069d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125022/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch">1.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch">2.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch">3.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/ea4bdd85-5e34-43f0-8c0f-70a357e42529__4.patch">4.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch">5.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>