[Kde-games-devel] Proposed patch for kdegames CMakeLists.txt

Albert Astals Cid aacid at kde.org
Fri Mar 30 19:11:41 CEST 2007


A Divendres 30 Març 2007, Mark A. Taff va escriure:
> On Friday 30 March 2007 00:19:16 Pino Toscano wrote:
> > Alle 08:55, venerdì 30 marzo 2007, Mark A. Taff ha scritto:
> > > I propose the attached patch to kdegames/CMakeLists.txt that sets the
> > > CMAKE_CXX_FLAGS to include the g++ -pedantic flag.
> >
> > I don't find it a good idea, just enabling it for a sinle specific
> > subdirectory. The best would be having it directly into kdelibs - if not,
> > activating it on the whole module would be better.
>
> It is a patch on the CMakeLists.txt for the whole kdegames module.  I think
> individual apps in the module could turn it off by setting it to an empty
> string in their own CMakeLists.txt file.
>
> I would support putting in kdelibs as well.

I'm with Pino there, it makes no sense defining it only in kdegames, please 
send a patch so it gets added to the whole kde building system if you think 
it's needed.

Albert

>
> Regards,
>
> Mark
>
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel




More information about the kde-games-devel mailing list