D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

[Hannah von Reth]

vonreth added a comment.


  I love it.
  Could we add a option to the exported target, so that you can basically always link that library with out an effect, until a cmake flag is set?
  This way we can bring it to all applications and enable it from craft.
  -DENABLE_BREEZE_BINARY_THEME=ON (or what ever)

INLINE COMMENTS

> main.cpp:32
> +    // decide if we want normal or dark theme based on application palette
> +    const auto darkTheme = qGuiApp->palette().color(QPalette::Base).lightness() < 128;
> +

I prefer lightnessF() < 0.5 here but that's a matter of taste ;D

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20201119/bb54cf21/attachment.htm>