D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrick j pereira noreply at phabricator.kde.org
Mon May 11 13:42:46 BST 2020


patrickelectric added inline comments.

INLINE COMMENTS

> kcolorcombo.cpp:67
>      // inner color
> +    QVariant tv = index.data(Qt::DisplayRole);
>      QVariant cv = index.data(ColorRole);

Missing const.

> kcolorcombo.cpp:69
>      QVariant cv = index.data(ColorRole);
> +    QColor innerColor = ((cv.type() == QVariant::Color) ? cv.value<QColor>() : QPalette::Base);
> +    

missing const.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200511/eb042008/attachment-0001.htm>


More information about the Kde-frameworks-devel mailing list