<table><tr><td style="">patrickelectric added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29502">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29502#inline-169616">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcolorcombo.cpp:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// inner color</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVariant</span> <span class="n">tv</span> <span style="color: #aa2211">=</span> <span class="n">index</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">DisplayRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QVariant</span> <span class="n">cv</span> <span style="color: #aa2211">=</span> <span class="n">index</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">ColorRole</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Missing const.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29502#inline-169617">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcolorcombo.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QVariant</span> <span class="n">cv</span> <span style="color: #aa2211">=</span> <span class="n">index</span><span class="p">.</span><span class="n">data</span><span class="p">(</span><span class="n">ColorRole</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QColor</span> <span class="n">innerColor</span> <span style="color: #aa2211">=</span> <span class="p">((</span><span class="n">cv</span><span class="p">.</span><span class="n">type</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">QVariant</span><span style="color: #aa2211">::</span><span class="n">Color</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span class="n">cv</span><span class="p">.</span><span class="n">value</span><span style="color: #aa2211"><</span><span class="n">QColor</span><span style="color: #aa2211">></span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">QPalette</span><span style="color: #aa2211">::</span><span class="n">Base</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing const.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29502">https://phabricator.kde.org/D29502</a></div></div><br /><div><strong>To: </strong>araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham<br /><strong>Cc: </strong>cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>