D29397: KPreviewJob : Support for DeviceRatioPixel

[David Faure]

dfaure added a comment.


  In D29397#664536 <https://phabricator.kde.org/D29397#664536>, @meven wrote:
  
  > In D29397#663800 <https://phabricator.kde.org/D29397#663800>, @dfaure wrote:
  >
  > > Oh, I thought it was sent as an int. But 8 is QImage::Format_ARGB8565_Premultiplied. Did you mean 0x80?
  >
  >
  > No I meant 8, since format is passed as quint8 (a single byte, 8-bit) and the format is forced to QImage::Format_ARGB32 "5", so this works.
  
  
  OK, this works today. But if one day we want to start actually using other image formats, we'll end up with a clash here.
  Why not use 0x80 in order to stay away from valid image format values? This seems safer to me, in the long run.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200506/0d865220/attachment.html>