D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

Henri Chain noreply at phabricator.kde.org
Mon Mar 30 09:20:30 BST 2020


hchain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kde-systemd-start-condition.cpp:17
> Should it be  showHelp(255)?
> 
> Not that we should end up here in the generated case.

I intentionally return 0 here to mimic the behavior of KAutostart which returns true if the condition is malformed or empty

> davidedmundson wrote in kde-systemd-start-condition.cpp:20
> A group name can have a space in it.
> 
> For example:
> X-KDE-autostart-condition=baloofilerc:Basic Settings:Indexing-Enabled:true
> 
> I assume this will be ok as long as we make sure that we make the generator put things in quotes. But can you double check.

so I could silently join the arguments with spaces ?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D28421

To: hchain, davidedmundson, broulik, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200330/8e6df969/attachment.html>


More information about the Kde-frameworks-devel mailing list