D28245: [xdgoutput] Only send initial name and description if set

[Vlad Zahorodnii]

zzag added a comment.


  In D28245#633649 <https://phabricator.kde.org/D28245#633649>, @davidedmundson wrote:
  
  > I interpreted the spec the same way when I wrote this...but we don't have a choice.
  
  
  I think we do.
  
  (a) Revert the recent xdg-output patches and land them in KF 5.70 or later. (Plasma 5.19 is going to depend on KF 5.70)
  
  (b) Introduce an API to indicate what version of the protocol is actually implemented by the compositor.
  
    m_xdgOutputManager = m_display->createXdgOutputManager(m_display);
    m_xdgOutputManager->setVersion(XdgOutputManagerV1Interface::V2);
    m_xdgOutputManager->create();
  
  I think it's okay to ship the current fix, but only temporarily.
  
  >> I believe it might be a problem
  > 
  > From a QtWayland POV it's fine at least.
  > 
  >> We should remove these ifs in KF 5.70.
  > 
  > Why then?
  > 
  > Removing them then would still break Plasma 5.18 and officially we support that combo
  > 
  > Plasma 5.19 will set the name/description, so removing the if won't change anything.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28245

To: davidedmundson, #kwin, zzag, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200324/3c2e74e8/attachment.html>