<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28245">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28245#633649" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D28245#633649</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I interpreted the spec the same way when I wrote this...but we don't have a choice.</p></div>
</blockquote>

<p>I think we do.</p>

<p>(a) Revert the recent xdg-output patches and land them in KF 5.70 or later. (Plasma 5.19 is going to depend on KF 5.70)</p>

<p>(b) Introduce an API to indicate what version of the protocol is actually implemented by the compositor.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span class="n">m_xdgOutputManager</span> <span style="color: #aa2211">=</span> <span class="n">m_display</span><span style="color: #aa2211">-></span><span class="n">createXdgOutputManager</span><span class="p">(</span><span class="n">m_display</span><span class="p">);</span>
<span class="n">m_xdgOutputManager</span><span style="color: #aa2211">-></span><span class="n">setVersion</span><span class="p">(</span><span class="n">XdgOutputManagerV1Interface</span><span style="color: #aa2211">::</span><span class="n">V2</span><span class="p">);</span>
<span class="n">m_xdgOutputManager</span><span style="color: #aa2211">-></span><span class="n">create</span><span class="p">();</span></pre></div>

<p>I think it's okay to ship the current fix, but only temporarily.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I believe it might be a problem</p></blockquote>

<p>From a QtWayland POV it's fine at least.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>We should remove these ifs in KF 5.70.</p></blockquote>

<p>Why then?</p>

<p>Removing them then would still break Plasma 5.18 and officially we support that combo</p>

<p>Plasma 5.19 will set the name/description, so removing the if won't change anything.</p></blockquote></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28245">https://phabricator.kde.org/D28245</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin, zzag, apol<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>