D28169: [DesktopExecParser] Let the service open protocols is claims to support

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in desktopexecparser.cpp:350
> Doesn't this break the special case in the comment below?
> VLC claims to support smb:// but if we have a password, we need to be able to pass it, so we want to use KIOFuse?
> 
> And then if you fix that, we're back to a simple revert of the last commit, no?

Indeed.

However I still think the condition is flawed:

- vlc.desktop says it supports smb:// so "supported" is true, !supported is false, we go the branch of ||, userName is not empty but password is empty, go to KIOFuse
- but what if both the userName and password _aren't_ empty, vlc is already out of the picture

IIUC, vlc has native smb support which will beat any FUSE equivalent, right?

I'll think about it some more.... :/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200320/c5e25f4d/attachment-0001.html>