D29258: Don't use notifybysnore.h on MSYS2

Łukasz Wojniłowicz noreply at phabricator.kde.org
Tue Apr 28 16:36:32 BST 2020


wojnilowicz created this revision.
wojnilowicz added reviewers: broulik, brute4s99.
wojnilowicz added a project: Frameworks.
wojnilowicz requested review of this revision.

REVISION SUMMARY
  SnoreToast fails to build on MSYS2 due to missing
  which apparently is not available for this compiler.
  
  This patch changes dependency on SnoreToast from required to optional.
  As a result, it allows to actually build KNotifications on MSYS2.

TEST PLAN
  Built application on Windows, which links to KNotifications.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29258

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/config-knotifications.h.cmake
  src/knotificationmanager.cpp

To: wojnilowicz, broulik, brute4s99
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200428/e23d50c5/attachment.html>


More information about the Kde-frameworks-devel mailing list