<table><tr><td style="">wojnilowicz created this revision.<br />wojnilowicz added reviewers: broulik, brute4s99.<br />wojnilowicz added a project: Frameworks.<br />wojnilowicz requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29258">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>SnoreToast fails to build on MSYS2 due to missing<br />
which apparently is not available for this compiler.</p>
<p>This patch changes dependency on SnoreToast from required to optional.<br />
As a result, it allows to actually build KNotifications on MSYS2.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Built application on Windows, which links to KNotifications.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 KNotifications</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29258">https://phabricator.kde.org/D29258</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
src/CMakeLists.txt<br />
src/config-knotifications.h.cmake<br />
src/knotificationmanager.cpp</div></div></div><br /><div><strong>To: </strong>wojnilowicz, broulik, brute4s99<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>