D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

David Faure noreply at phabricator.kde.org
Fri Apr 17 22:50:16 BST 2020


dfaure added inline comments.

INLINE COMMENTS

> meven wrote in trashimpl.cpp:1105
> Maybe, check for `details & KIO::StatTime`
> Down the rabbit hole...

Well, if StatRecursiveSize is set, we have the info, so we might as well provide it.

If it's not set, then this would mean we need to do the whole recursive thing also when StatTime is set, and it's part of StatDefaultDetails so I expect we'll do this often for nothing. I think we don't really want to do that, in practice we need both pieces of information, or none.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200417/a449060e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list