D28528: UDSEntry: add constructor variant with std::initializer_list

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Apr 3 02:15:20 BST 2020


apol added inline comments.

INLINE COMMENTS

> udsentry.h:127
> +    // holds either the numeric or the string value
> +    // done to avoid unneeded QString constructor & destructor in case of numeric value
> +    union U {

I'm not sure, it skips the constructor/destructor, but then when it's a string we need to do a memcopy. Are you sure this is faster than the refcounting?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28528

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/f12761ca/attachment.html>


More information about the Kde-frameworks-devel mailing list