D28488: [Fstab] Ensure uniqueness for all filesystem types

Méven Car noreply at phabricator.kde.org
Thu Apr 2 09:11:25 BST 2020


meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  Good idea, we should fix this once and for all.
  Two points though about udi form :
  
  1/ Nfs udi would no be great.
  For instance the source for nfs is usually of the form :
  192.168.0.1:/export
  
  With this we would have 
  192.168.0.1:/export:/mountpount
  
  I suggest for the nfs source to remove the first ':' in the first place
  To get :
  192.168.0.1/export:@mountpount for nfs
  
  2/ For fuse mounts this removes the fstype from the udi, which is present currently for this case and handy.
  So perhaps we would want to use the fstype :
  
  nfs/192.168.0.1/export:mountpount for nfs
  cifs//server/export:mountpoint for cifs (perhaps without the double slash)
  fuse.type/source/export:mountpount for fuse
  sftp/username at source/export:mountpoint for sftp
  
  Perhaps event fstype:/ to make the fstype look like a protocol in the udi, i.e : `fuse.type:/source/export:mountpount` and `sftp:/username at source/export:mountpoint for sftp`
  A complete udi would like like:
  `/orge/kde/fstab/sftp:/username at source/export:mountpoint`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28488

To: bruns, #frameworks, meven, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/8f7d7928/attachment.html>


More information about the Kde-frameworks-devel mailing list