<table><tr><td style="">meven requested changes to this revision.<br />meven added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28488">View Revision</a></tr></table><br /><div><div><p>Good idea, we should fix this once and for all.<br />
Two points though about udi form :</p>
<p>1/ Nfs udi would no be great.<br />
For instance the source for nfs is usually of the form :<br />
192.168.0.1:/export</p>
<p>With this we would have <br />
192.168.0.1:/export:/mountpount</p>
<p>I suggest for the nfs source to remove the first ':' in the first place<br />
To get :<br />
192.168.0.1/export:<span class="phabricator-remarkup-mention-unknown">@mountpount</span> for nfs</p>
<p>2/ For fuse mounts this removes the fstype from the udi, which is present currently for this case and handy.<br />
So perhaps we would want to use the fstype :</p>
<p>nfs/192.168.0.1/export:mountpount for nfs<br />
cifs//server/export:mountpoint for cifs (perhaps without the double slash)<br />
fuse.type/source/export:mountpount for fuse<br />
sftp/username@source/export:mountpoint for sftp</p>
<p>Perhaps event fstype:/ to make the fstype look like a protocol in the udi, i.e : <tt style="background: #ebebeb; font-size: 13px;">fuse.type:/source/export:mountpount</tt> and <tt style="background: #ebebeb; font-size: 13px;">sftp:/username@source/export:mountpoint for sftp</tt><br />
A complete udi would like like:<br />
<tt style="background: #ebebeb; font-size: 13px;">/orge/kde/fstab/sftp:/username@source/export:mountpoint</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28488">https://phabricator.kde.org/D28488</a></div></div><br /><div><strong>To: </strong>bruns, Frameworks, meven, broulik<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>