D21183: search in the new location for knsrc files

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:49
>  
> -    const auto knsname = QStandardPaths::locate(QStandardPaths::GenericConfigLocation, url.host());
> +    auto knsname = QStandardPaths::locate(QStandardPaths::GenericDataLocation, QStringLiteral("knsrcfiles/") + url.host());
> +    if (knsname.isEmpty()) {

Since frameworkintegration requires KNewStuff (and Frameworks 5.58), i'd probably suggest using the static function in KNewStuffCore::Engine which gives you this information without having to do manual heuristic type stuff :)

static QStringList Engine::configSearchLocations(bool includeFallbackLocations = false):
https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Engine.html#a030b62a72c0c486939461983e225bb49

> main.cpp:116
>  //         qDebug() << "checking..." << entry.status() << entry.providerId();
> -        if (providerid != QUrl(entry.providerId()).host()) {
> +        if (0&&providerid != QUrl(entry.providerId()).host()) {
>              qWarning() << "Wrong provider" << providerid << "instead of" << QUrl(entry.providerId()).host();

Did you mean to leave this in?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D21183

To: mart, #plasma, leinir
Cc: leinir, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190513/b2311e9c/attachment-0001.html>