<table><tr><td style="">leinir requested changes to this revision.<br />leinir added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21183">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21183#inline-118835">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">knsname</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QStandardPaths</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">locate</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStandardPaths</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">GenericConfigLocation</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">url</span><span class="p">.</span><span class="n">host</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">knsname</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">QStandardPaths</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">locate</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStandardPaths</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">GenericDataLocation</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QStringLiteral</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"knsrcfiles/"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span> <span class="n">url</span><span class="p">.</span><span class="n">host</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">knsname</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since frameworkintegration requires KNewStuff (and Frameworks 5.58), i'd probably suggest using the static function in KNewStuffCore::Engine which gives you this information without having to do manual heuristic type stuff :)</p>

<p style="padding: 0; margin: 8px;">static QStringList Engine::configSearchLocations(bool includeFallbackLocations = false):<br />
<a href="https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Engine.html#a030b62a72c0c486939461983e225bb49" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Engine.html#a030b62a72c0c486939461983e225bb49</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21183#inline-118833">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:116</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">//         qDebug() << "checking..." << entry.status() << entry.providerId();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">providerid</span> <span style="color: #aa2211">!=</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">providerId</span><span class="p">()).</span><span class="n">host</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="n">providerid</span> <span style="color: #aa2211">!=</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">providerId</span><span class="p">()).</span><span class="n">host</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">qWarning</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Wrong provider"</span> <span style="color: #aa2211"><<</span> <span class="n">providerid</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"instead of"</span> <span style="color: #aa2211"><<</span> <span class="n">QUrl</span><span class="p">(</span><span class="n">entry</span><span class="p">.</span><span class="n">providerId</span><span class="p">()).</span><span class="n">host</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you mean to leave this in?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R252 Framework Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21183">https://phabricator.kde.org/D21183</a></div></div><br /><div><strong>To: </strong>mart, Plasma, leinir<br /><strong>Cc: </strong>leinir, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>