D20735: [KPropertiesDialog] Add octal permissions

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  The permission changes to ktelnetservice5.desktop are unrelated, please revert them.
  
  Mostly important, the value shown in the advanced permissions dialog is not taking into account the changes done in the properties dialog of the file. The other widgets in this advanced dialog already do, so the shown octal value ought to as well.

INLINE COMMENTS

> kpropertiesdialog.cpp:2114
> +    // Add Octal permissions to the dialog
> +    l = new QLabel(i18n("Octal: %1", QString::fromLatin1("%1").arg(itemPermission, 0, 8)), gb);
> +    gl->addWidget(l, 0, 0, Qt::AlignRight);       

just use the static QString::number?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino, #vdg
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190502/9b7ed0d4/attachment-0001.html>