<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20735">View Revision</a></tr></table><br /><div><div><p>The permission changes to ktelnetservice5.desktop are unrelated, please revert them.</p>

<p>Mostly important, the value shown in the advanced permissions dialog is not taking into account the changes done in the properties dialog of the file. The other widgets in this advanced dialog already do, so the shown octal value ought to as well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20735#inline-117736">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpropertiesdialog.cpp:2114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// Add Octal permissions to the dialog</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">l</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Octal: %1"</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">fromLatin1</span><span class="p">(</span><span style="color: #766510">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">itemPermission</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">8</span><span class="p">)),</span> <span class="n">gb</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">gl</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span class="n">l</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">AlignRight</span><span class="p">);</span>       
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">just use the static QString::number?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20735">https://phabricator.kde.org/D20735</a></div></div><br /><div><strong>To: </strong>shubham, ngraham, pino, VDG<br /><strong>Cc: </strong>mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>