D22763: [KDirOperator] Use more human-readable sort order descriptions

Méven Car noreply at phabricator.kde.org
Sat Jul 27 18:07:01 BST 2019


meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in kdiroperator.cpp:1992
> Why change this? kdiroperator should definitely be ported to use the new connect syntax, but it should be done all at once in its own patch, not one at a time.

_k_slotSortReversed parameter means whether or not the sorting is reversed.
Before this change, the descending action was a check box meaning its value should be the parameter to _k_slotSortReversed.
But now the descending action is a radio button meaning when triggered it should always pass false to _k_slotSortReversed.

A closure was the simple course of action to implement this, and could be reused as is for the ascending action as well.
Onyl the new syntax allows closures to be used as slots.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22763

REVISION DETAIL
  https://phabricator.kde.org/D22763

To: meven, ngraham, #frameworks, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190727/1eb40639/attachment.html>


More information about the Kde-frameworks-devel mailing list