D22763: [KDirOperator] Use more human-readable sort order descriptions

Nathaniel Graham noreply at phabricator.kde.org
Sat Jul 27 15:44:23 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:1992
> +    descendingAction->setActionGroup(sortOrderGroup);
> +    connect(descendingAction, &QAction::triggered, this, [this]() {
> +        this->d->_k_slotSortReversed(true);

Why change this? kdiroperator should definitely be ported to use the new connect syntax, but it should be done all at once in its own patch, not one at a time.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22763

REVISION DETAIL
  https://phabricator.kde.org/D22763

To: meven, ngraham, #frameworks, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190727/224e9b70/attachment.html>


More information about the Kde-frameworks-devel mailing list