D22723: Fix RunnerManager::queryFinished()

Fabian Vogt noreply at phabricator.kde.org
Wed Jul 24 19:27:27 BST 2019


fvogt added a reviewer: davidedmundson.
fvogt added a comment.


  Looks like a hack still, with two Job objects for each job...
  
  What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by basically just adding a custom `done` signal and ignoring the entire "decorators which are actually wrappers" business?
  
  IMO this new `FindMatchesJobInternal` class makes it even less obvious what's actually going on.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190724/edb4c4e6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list