D22723: Fix RunnerManager::queryFinished()

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jul 24 18:50:04 BST 2019


apol created this revision.
apol added reviewers: Frameworks, fvogt.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  This actually looks like the port to the QObjectDecorator was done wrong. QObjectDecorator::done was never emitted because the decorator doesn't notify about changes in the decoratee (which is potentially something to improve in ThreadWeaver).
  This patch changes the internal FindMatchesJob to be a QObjectDecorator which will allow us to get notified when the jobs get done.
  
  Deprecates D21606 <https://phabricator.kde.org/D21606> which forced emitting done from the thread.

TEST PLAN
  Tested with D22514 <https://phabricator.kde.org/D22514>

REPOSITORY
  R308 KRunner

BRANCH
  arcpatch-D21606_1

REVISION DETAIL
  https://phabricator.kde.org/D22723

AFFECTED FILES
  src/runnerjobs.cpp
  src/runnerjobs_p.h
  src/runnermanager.cpp

To: apol, #frameworks, fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190724/3c9c10b9/attachment.html>


More information about the Kde-frameworks-devel mailing list