D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Harald Sitter]

sitter updated this revision to Diff 61522.
sitter marked 14 inline comments as done.
sitter added a comment.


  - running property gone since we have no use case + simplified code since we no longer account for it
  - dropped superfluous virtual keywords
  - bumped duration to 1.5s
  - moved to qvariantanimation + alloc animation on stack
  - now has minimumsizehint based on PM_SmallIconSize
  
  I am actually not sure about what needs overriding for best sizehiniting, I figure minimumsizehint is the bare minimum? Should we also set a sizehint?

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22375?vs=61506&id=61522

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

AFFECTED FILES
  src/CMakeLists.txt
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  tests/CMakeLists.txt
  tests/kbusyindicatorwidgettest.cpp

To: sitter, cfeck
Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190710/83e5ba4b/attachment.html>