D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> sitter wrote in kbusyindicatorwidget.h:48
> Mimics the QML API, haven't given it any thought TBH. You can have the spinner visible but paused, I am not sure why exactly you'd want a paused spinner but that's what the property does anyway.
> 
> i.e.
> 
> - you can have a visible but !running spinner which would simply be the spinner at whatever the last rotation update was.
> - a visibile and running spinner = animation
> - a running but !visible spinner = effectively noop
> 
> That said, **I** have no use case for it so we can remove it for the time being if you'd prefer.

Please remove it unless you find a justification. I don't like its name either (the widget isn't running).

> kbusyindicatorwidget.h:72
> +    class Private;
> +    Private *d;
> +};

`*const d`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck
Cc: broulik, kde-frameworks-devel, apol, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190710/080fbc40/attachment.html>