D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

[David Faure]

dfaure added a comment.


  This test breaks KFileItemTest: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/136/testReport/junit/projectroot/autotests/kiocore_kfileitemtest/
  QDEBUG : KFileItemTest::testIconNameForUrl(root) QUrl("file:///")
  FAIL!  : KFileItemTest::testIconNameForUrl(root) Compared values are not the same
  
    Actual   (KIO::iconNameForUrl(url)): "inode-directory"
    Expected (expectedIcon)            : "folder"
  
  But maybe that's an improvement, in case all that needs to be done is to fix the test. In any case, please investigate.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190706/1c66ae99/attachment.html>