<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13048">View Revision</a></tr></table><br /><div><div><p>This test breaks KFileItemTest: <a href="https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/136/testReport/junit/projectroot/autotests/kiocore_kfileitemtest/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/136/testReport/junit/projectroot/autotests/kiocore_kfileitemtest/</a><br />
QDEBUG : KFileItemTest::testIconNameForUrl(root) QUrl("file:///")<br />
FAIL!  : KFileItemTest::testIconNameForUrl(root) Compared values are not the same</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Actual   (KIO::iconNameForUrl(url)): "inode-directory"
Expected (expectedIcon)            : "folder"</pre></div>

<p>But maybe that's an improvement, in case all that needs to be done is to fix the test. In any case, please investigate.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13048">https://phabricator.kde.org/D13048</a></div></div><br /><div><strong>To: </strong>ngraham, Frameworks, broulik, meven, apol, dfaure<br /><strong>Cc: </strong>apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns<br /></div>