D16826: Treat uints and doubles the same as integers

[Stefan Brüns]

bruns added a comment.


  I think support for non-integers is useful in general, but there are a few things we should consider:
  
  Currently, only integral numbers can be searched. For floats, we definitely want Less/Greater matches to work, exact matches for floats are not very useful.
  
  As you are referring to the TermGenerator, I suppose the (float) variant gets converted to something like "-5.73",  which is mangled by the TermGenerator to something like "X42-5.73", i.e. dropping the sign? (See D17284 <https://phabricator.kde.org/D17284>)
  
  Ideally, this were backed by some unit tests. The comparision test can be added to the postingdbtest, but AFAICS there are currently no tests covering `Baloo::Result`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181201/99959ca7/attachment.html>