<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16826">View Revision</a></tr></table><br /><div><div><p>I think support for non-integers is useful in general, but there are a few things we should consider:</p>
<p>Currently, only integral numbers can be searched. For floats, we definitely want Less/Greater matches to work, exact matches for floats are not very useful.</p>
<p>As you are referring to the TermGenerator, I suppose the (float) variant gets converted to something like "-5.73", which is mangled by the TermGenerator to something like "X42-5.73", i.e. dropping the sign? (See <a href="https://phabricator.kde.org/D17284" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D17284</a>)</p>
<p>Ideally, this were backed by some unit tests. The comparision test can be added to the postingdbtest, but AFAICS there are currently no tests covering <tt style="background: #ebebeb; font-size: 13px;">Baloo::Result</tt></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16826">https://phabricator.kde.org/D16826</a></div></div><br /><div><strong>To: </strong>astippich, bruns, Baloo<br /><strong>Cc: </strong>ngraham, kde-frameworks-devel, Baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams<br /></div>