GSoC 21 KMyMoney: Replacing member functions of WebPriceQuote

[Suraj Kumar Mahto]

Hello,
https://invent.kde.org/office/kmymoney/-/blob/master/kmymoney/dialogs/kequitypriceupdatedlg.cpp#L274
Here kmm-online-source is of type QString but AlkOnlineQuoteSource ctor
accepts const AlkOnlineQuoteSource& as argument(other ctors either accepts
no argument or more than one argument). For that should I write a new ctor
for that use case or modify the existing one or am I missing something else?

I will surely publish my week 3-4-5 blog by tomorrow.

Regards
Suraj Kumar Mahto

On Sat, Jul 10, 2021 at 11:30 AM Thomas Baumgart <thb at net-bembel.de> wrote:

> On Freitag, 9. Juli 2021 21:07:36 CEST Suraj Kumar Mahto wrote:
>
> > >
> > > While writing the getter and setter for m_idSelector which is of type
> enum
> > > and defined in alkonlinequotesource.cpp whereas the declarations of the
> > > getters and setters are in alkonlinequotesource.h therefore I can't
> declare
> > > the function of type idSelector (enum). What should I do for that case?
> > >
> >
> > The solution I thought was to shift all the declarations to the header
> file
> > or shift the enum declaration to public in the header file or somewhere
> > else. Though, I am unsure about both.
>
> I would move the definition of the enum to public in AlkOnlineQuoteSource.
> After all, you use it in the public interface (getter and setter) and
> therefore
> it needs to be there.
>
> Check AlkValue::RoundingMethod how the definition can look like.
> You can use the definitions in AlkOnlineQuoteSource::Private without
> problems
> as they are publicly available.
>
> Hope that helps.
>
> --
>
> Regards
>
> Thomas Baumgart
>
> https://www.signal.org/       Signal, the better WhatsApp
> -------------------------------------------------------------
> Programmers never die: They just GOSUB without RETURN.
> -------------------------------------------------------------
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20210710/e3601e3f/attachment.htm>