Review Request: Proposed fix for Krita Bug 276984 - Text/shape handles leave artefacts when text/shape is moved

[Sven Langkamp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105764/#review16557
-----------------------------------------------------------


This doesn't completely fix the problem. It kinda works for the text shape as the shape changes at the same time as the selection. It does not work when only the tool changes something, like the blue rubber band when you select something with the default tool.

Probably needs to be fixed on tool/canvas level as only there the exactly rect is available.

- Sven Langkamp


On July 28, 2012, 12:21 a.m., Michael O'Sullivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105764/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 12:21 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Artefacts from shape handles are painted if a shape is moved slowly towards the top left of the canvas. An area around the shape is cleared upon mouse release, but an artefact trail remains if the shape has been moved a significant distance. 
> 
> In void KisShapeLayerCanvas::updateCanvas(const QRectF& rc)
> a QRect r was originally adjusted by (-2,-2, 2, 2) to cater for antialiasing (according to a comment there). Changing the adjust factor to (-2,-2, 5, 5) was sufficient to stop artefacts appearing when moving a rectangle at 300 ppi resolution. Artefacts were still present when text was moved however. Setting the adjust factors to (-10,-10,10,10) stopped artefacts appearing for the text box at 300 ppi, but not at 600 ppi. Setting the adjust factor to (-10,-10,20,20) prevented text box artefacts at 600 and 1000 ppi, and this is the set of factors submitted in the patch.
> 
> 
> This addresses bug 276984.
>     http://bugs.kde.org/show_bug.cgi?id=276984
> 
> 
> Diffs
> -----
> 
>   krita/ui/flake/kis_shape_layer_canvas.cpp 9a86cc0 
> 
> Diff: http://git.reviewboard.kde.org/r/105764/diff/
> 
> 
> Testing
> -------
> 
> Tested moving shapes and text boxes at 300, 600, and 1000 ppi.
> 
> 
> Thanks,
> 
> Michael O'Sullivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120728/80d374c1/attachment.htm>