<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105764/">http://git.reviewboard.kde.org/r/105764/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This doesn't completely fix the problem. It kinda works for the text shape as the shape changes at the same time as the selection. It does not work when only the tool changes something, like the blue rubber band when you select something with the default tool.
Probably needs to be fixed on tool/canvas level as only there the exactly rect is available.</pre>
<br />
<p>- Sven</p>
<br />
<p>On July 28th, 2012, 12:21 a.m., Michael O'Sullivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael O'Sullivan.</div>
<p style="color: grey;"><i>Updated July 28, 2012, 12:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Artefacts from shape handles are painted if a shape is moved slowly towards the top left of the canvas. An area around the shape is cleared upon mouse release, but an artefact trail remains if the shape has been moved a significant distance.
In void KisShapeLayerCanvas::updateCanvas(const QRectF& rc)
a QRect r was originally adjusted by (-2,-2, 2, 2) to cater for antialiasing (according to a comment there). Changing the adjust factor to (-2,-2, 5, 5) was sufficient to stop artefacts appearing when moving a rectangle at 300 ppi resolution. Artefacts were still present when text was moved however. Setting the adjust factors to (-10,-10,10,10) stopped artefacts appearing for the text box at 300 ppi, but not at 600 ppi. Setting the adjust factor to (-10,-10,20,20) prevented text box artefacts at 600 and 1000 ppi, and this is the set of factors submitted in the patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested moving shapes and text boxes at 300, 600, and 1000 ppi.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=276984">276984</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/flake/kis_shape_layer_canvas.cpp <span style="color: grey">(9a86cc0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105764/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>