[Amarok] Check to make sure mysql server hasn't gone away b

[Jeff Mitchell]

Ian Monroe wrote:
> On Sun, Oct 4, 2009 at 6:01 PM, Jeff Mitchell <mitchell at kde.org> wrote:
>> Peter C. Ndikuwera wrote:
>>> This patch breaks my amarok. I'm using the MySQL server
>>>
>>> See attached crash dump.
>>>
>>> When I comment out the block with mysql_ping in it, I run fine.
>> Yes, I'm aware of the problem.
>>
>> Just not the cause.
> 
> MySqlCollection::query has this code:
>     if( !m_db )
>     {
>         error() << "Tried to perform query on uninitialized MySQL";
>         return values;
>     }
> 
> Which is missing in the override. So I'm guessing a null m_db is possible.
> 
> It also has a mutex.

Thanks for doing the legwork for me, I've been busy and didn't notice
this at the time of coding.

Fixes being committed shortly.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/amarok/attachments/20091004/67fb21a3/attachment.sig>