[WebKit-devel] [kwebkitpart] [Bug 313005] Some links are opened in a new window instead of a new tab with QtWebkit 2.3

[Dawit Alemayehu]

https://bugs.kde.org/show_bug.cgi?id=313005

Dawit Alemayehu <adawit at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |1.3 branch
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kweb
                   |                            |kitpart/d786bbdcb4863477780
                   |                            |9461b4900ab309b9f690f

--- Comment #3 from Dawit Alemayehu <adawit at kde.org> ---
Git commit d786bbdcb48634777809461b4900ab309b9f690f by Dawit Alemayehu.
Committed on 23/02/2013 at 17:27.
Pushed by adawit into branch '1.3'.

Workaround QtWebKit 2.3's behavior change when emitting
'QWebPage::geometryChangeRequested'.
For some reason it now sends a default width and height of 100 on new window
creation even
when the site did not specify those dimensions.

NOTE: This workaround will cause a regression if a site attempts to create a
popup window
using Javascripts with the following parameters: x=0,y=0,width=100,height=100.
Under that
circumstance, the window will end up being created as another tab in konqueror
instead of
a popup window.
FIXED-IN: 1.3 branch

M  +21   -1    src/webpage.cpp

http://commits.kde.org/kwebkitpart/d786bbdcb48634777809461b4900ab309b9f690f

-- 
You are receiving this mail because:
You are the assignee for the bug.