[WebKit-devel] [Bug 261223] Download name of link targets containing special characters get ignored

[Rolf Eike Beer]

https://bugs.kde.org/show_bug.cgi?id=261223





--- Comment #19 from Rolf Eike Beer <kde opensource sf-tec de>  2011-03-01 22:44:49 ---
> > Agreed. But I find the isPrint() conversion doubtful. Please also make
> > sure all existing testcases work properly.
> 
> Why do you think the isPrint() conversion is doubtful ? It correctly
> excludes every control character, which includes the vertical and
> horizontal spacers (\v, \t, \n, \r), while making it possible to allow
> unicode characters present in the string.
> 
> On top of that all the test cases pass as well...

Hm, that change seems to be one of the central points of this change, no? ;) 
Ok, ignore me then. I'll review that one tomorrow again when I'm less 
confused.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.